Guidelines for contributing¶
Summary¶
PRs welcome!
- Consider starting a discussion to see if there's interest in what you want to do.
- Fork the repo and submit PRs from the fork.
- Ensure PRs pass all CI checks.
- Maintain test coverage at 100%.
Git¶
- Why use Git? Git enables creation of multiple versions of a code repository called branches, with the ability to track and undo changes in detail.
- Install Git by downloading from the website, or with a package manager like Homebrew.
- Configure Git to connect to GitHub with SSH.
- Fork this repo.
- Create a branch in your fork.
- Commit your changes with a properly-formatted Git commit message.
- Create a pull request (PR) to incorporate your changes into the upstream project you forked.
Python¶
Hatch¶
This project uses Hatch for dependency management and packaging.
Highlights¶
- Automatic virtual environment management: Hatch automatically manages the application environment.
- Dependency resolution: Hatch will automatically resolve any dependency version conflicts using the
pip
dependency resolver. - Dependency separation: Hatch supports separate lists of optional dependencies in the pyproject.toml. Production installs can skip optional dependencies for speed.
- Builds: Hatch has features for easily building the project into a Python package and publishing the package to PyPI.
Installation¶
Hatch can be installed with Homebrew or pipx
.
Install project with all dependencies: hatch env create
.
Key commands¶
# Basic usage: https://hatch.pypa.io/latest/cli/reference/
hatch env create # create virtual environment and install dependencies
hatch env find # show path to virtual environment
hatch env show # show info about available virtual environments
hatch run COMMAND # run a command within the virtual environment
hatch shell # activate the virtual environment, like source venv/bin/activate
hatch version # list or update version of this package
export HATCH_ENV_TYPE_VIRTUAL_PATH=.venv # install virtualenvs into .venv
Testing with pytest¶
- Tests are in the tests/ directory.
- pytest features used include:
- pytest plugins include:
- pytest configuration is in pyproject.toml.
- Run tests with pytest and coverage.py with
hatch run coverage run
. - Test coverage reports are generated by coverage.py. To generate test coverage reports:
- Run tests with
hatch run coverage run
- Generate a report with
hatch run coverage report
. To see interactive HTML coverage reports, runhatch run coverage html
instead.
- Run tests with
Code quality¶
Running code quality checks¶
Code quality checks can be run using the Hatch scripts in pyproject.toml.
- Check:
hatch run check
- Format:
hatch run format
Code style¶
- Python code is formatted with Ruff. Ruff configuration is stored in pyproject.toml.
- Other web code (JSON, Markdown, YAML) is formatted with Prettier.
Static type checking¶
- To learn type annotation basics, see the Python typing module docs, Python type annotations how-to, the Real Python type checking tutorial, and this gist.
- Type annotations are not used at runtime. The standard library
typing
module includes aTYPE_CHECKING
constant that isFalse
at runtime, butTrue
when conducting static type checking prior to runtime. Type imports are included underif TYPE_CHECKING:
conditions so that they are not imported at runtime. These conditions are ignored when calculating test coverage. - Type annotations can be provided inline or in separate stub files. Much of the Python standard library is annotated with stubs. For example, the Python standard library
logging.config
module uses type stubs. The typeshed types for thelogging.config
module are used solely for type-checking usage of thelogging.config
module itself. They cannot be imported and used to type annotate other modules. - basedpyright is used for type-checking. See the basedpyright docs for a comparison with mypy, the type checker used in this project previously. The basedpyright VSCode/VSCodium extension provides a Python language server.
Spell check¶
Spell check is performed with CSpell. The CSpell command is included in the Hatch script for code quality checks (hatch run check
).
GitHub Actions workflows¶
GitHub Actions is a continuous integration/continuous deployment (CI/CD) service that runs on GitHub repos. It replaces other services like Travis CI. Actions are grouped into workflows and stored in .github/workflows. See Getting the Gist of GitHub Actions for more info.
Maintainers¶
- PRs should be merged into the default branch. Head branches are deleted automatically after PRs are merged.
- Branch protection is enabled.
- Require signed commits
- Include administrators
- Do not allow force pushes
- Require status checks to pass before merging
- To create a release:
- Bump the version number in
__version__
withhatch version
and commit the changes.- Follow SemVer guidelines when choosing a version number. Note that PEP 440 Python version specifiers and SemVer version specifiers differ, particularly with regard to specifying prereleases. Use syntax compatible with both.
- The PEP 440 default (like
1.0.0a0
) is different from SemVer. Hatch and PyPI will use this syntax by default. - An alternative form of the Python prerelease syntax permitted in PEP 440 (like
1.0.0-alpha.0
) is compatible with SemVer, and this form should be used when tagging releases. As Hatch uses PEP 440 syntax by default, prerelease versions need to be written directly into__version__
. - Examples of acceptable tag names:
1.0.0
,1.0.0-alpha.0
,1.0.0-beta.1
- Push the version bump and verify all CI checks pass.
- Create an annotated and signed Git tag.
- List PRs and commits in the tag message:
git log --pretty=format:"- %s (%h)" \ "$(git describe --abbrev=0 --tags)"..HEAD
- Omit the leading
v
(use1.0.0
instead ofv1.0.0
) - Example:
git tag -a -s 1.0.0
- List PRs and commits in the tag message:
- Push the tag. GitHub Actions will build and push the Python package and Docker images, and open a PR to update the changelog.
- Squash and merge the changelog PR
- Bump the version number in